Reintroduce and deprecate Order#deliver_order_confirmation_email #3485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was removed as part of solidusio#3081, but not being private it's better to keep it around with a deprecation for a while.
houndci-bot
reviewed
Jan 23, 2020
kennyadsl
approved these changes
Feb 3, 2020
kennyadsl
deleted the
elia/deprecation-warning-for-order-deliver_order_confirmation_email
branch
MadelineCollier
added a commit
to SuperGoodSoft/solidus
that referenced
this pull request
Jul 26, 2022
When this method was re-introduced in solidusio#3485 with the purpose of adding a deprecation warning, the reintroduced method had a bug where `order` was being called on the order (instead of self). Co-authored-by: Adam Mueller <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Was removed as part of #3081, but not being private it's better to keep it around with a deprecation for a while.
I think it's worth merging this just into v2.9, perhaps updating the deprecation text to mention that will be removed in v2.10.
Checklist: