Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Change shipment email checkbox label #3490

Merged

Conversation

kennyadsl
Copy link
Member

Description

This quick PR changes the label of a checkbox in the admin, order shipments page:

Schermata 2020-01-25 alle 13 45 56

I think that it's not immediately clear what it refers to and "mailer" is also probably not the right word.

Schermata 2020-01-25 alle 13 57 29

Of course, waiting for a native English confirmation here.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

It's not immediately clear what it refers to and mailer is
also probably not the right word.
@kennyadsl kennyadsl added type:enhancement Proposed or newly added feature changelog:solidus_backend Changes to the solidus_backend gem labels Jan 25, 2020
@kennyadsl kennyadsl self-assigned this Jan 25, 2020
@kennyadsl kennyadsl merged commit b90365d into solidusio:master Jan 29, 2020
@kennyadsl kennyadsl deleted the kennyadsl/adjust-send-mail-label branch January 29, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_backend Changes to the solidus_backend gem type:enhancement Proposed or newly added feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants