Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a better name for CheckoutController#set_state_if_present #3496

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Use a better name for CheckoutController#set_state_if_present #3496

merged 1 commit into from
Feb 19, 2020

Conversation

elia
Copy link
Member

@elia elia commented Jan 29, 2020 •
edited
Loading

Description

The original name was quite detached from what the method is doing.

Ref: #3406 (comment)

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@elia
Use a better name for CheckoutController#set_state_if_present
119b259 
The original name was quite detached from what the method is doing.

Ref: solidusio#3406 (comment)
@elia elia mentioned this pull request Jan 29, 2020
Merged
2 tasks
@elia elia marked this pull request as ready for review February 14, 2020 11:28
spaghetticode
spaghetticode approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elia thank you 👍

@kennyadsl kennyadsl merged commit bc599de into solidusio:master Feb 19, 2020
@kennyadsl kennyadsl deleted the elia/rename-checkout_controller-set_state_if_present branch February 19, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elia @spaghetticode @kennyadsl