Remove conditional code that targets Rails 5.1 #3505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| unless RAILS_52_OR_ABOVE | ||
| protect_from_forgery with: :exception | ||
| end | ||
| protect_from_forgery with: :exception |
There was a problem hiding this comment.
This code was executed only when RAILS_52_OR_ABOVE was false, so I think the line should be removed
Adding some longer config would result in changing all of them and breaking git history everytime.
It was under a conditional block but now it makes no sense to have it separate from the other configurations.
kennyadsl
force-pushed
the
kennyadsl/remove-rails-5-1-code
branch
from
5c01338 to
badd349
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🧹🧹🧹🧹
We still have some conditional code that targets Rails 5.1, which has been deprecated and we do not support anymore.
This PR removes that code in order to keep the codebase as clean as possible.
Checklist:
[ ] I have updated Guides and README accordingly to this change (if needed)[ ] I have added tests to cover this change (if needed)[ ] I have attached screenshots to this PR for visual changes (if needed)