Allow multiple events subscription with regexp #3512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skukx
reviewed
Feb 13, 2020
skukx
approved these changes
Feb 14, 2020
kennyadsl
reviewed
Feb 18, 2020
|
While working on this PR I noticed the illogic situation exposed in #3519. I think that PR needs attention and to be merged before this one. |
spaghetticode
force-pushed
the
spaghetticode/regexp-event-subscription
branch
from
052fcbe to
cadf034
Compare
houndci-bot
reviewed
Feb 28, 2020
core/spec/lib/spree/event/adapters/active_support_notifications_spec.rb
Outdated
Show resolved
Hide resolved
`Spree::Event` events can now be subscribed also using regexp event names, when using the default ActiveSupportNotification adapter. As ActiveSupportNotification can manage regexp when subscribing to events, it makes sense to allow `Spree::Event` to leverage this feature. Every specific adapter can decide independently their supported event name types.
The documentation now includes explanations on using Regexp for subscribing to multiple events and its gotcha.
spaghetticode
force-pushed
the
spaghetticode/regexp-event-subscription
branch
from
cadf034 to
3c3475e
Compare
gmacdougall
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #3481
Spree::Eventevents can now be subscribed also using regexp event names, when using the default ActiveSupportNotification adapter.As ActiveSupportNotification can manage regexp when subscribing to events, it makes sense to allow
Spree::Eventto leverage this feature.Every specific adapter can decide independently their supported event name types.
Checklist: