[Guides] Improve extensions pages #3522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
changed the title
| Here's an example `.travis.yml` testing versions 2.2 through 2.7 and the | ||
| `master` branch: | ||
| Here's an example `.circleci/config.yml` file that you should have in your | ||
| extension: |
There was a problem hiding this comment.
What about linking to the file with this content instead? That way, if we change something, we don't need to revise the doc as well.
There was a problem hiding this comment.
Good idea, but I'll link this file, since it's what is copied in extensions when creating them. Does it work?
This explains why we created the CircleCI Orb [1] and how to use it. Travis configuration has been removed from all supported extensions. [1]: https://github.com/solidusio/circleci-orbs-extensions
kennyadsl
force-pushed
the
kennyadsl/improve-guides-extensions
branch
from
1f5d458 to
fd1501e
Compare
kennyadsl
changed the title
ericsaupe
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It replaces all occurrences of
solidus_cmdwithsolidus_dev_support.This PR also removes references to TravisCI in favor of the new CirlceCI Orb configuration for extensions.
Checklist:
[ ] I have updated Guides and README accordingly to this change (if needed)[ ] I have added tests to cover this change (if needed)[ ] I have attached screenshots to this PR for visual changes (if needed)