Remove code from Spree::Api::PromotionsController #3529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
reviewed
Mar 3, 2020
SamuelMartini
force-pushed
the
SamuelMartini/lean_promotions_controller
branch
from
8b14eb5 to
c5551e2
Compare
There was a problem hiding this comment.
@SamuelMartini thank you for this PR, looks good to me, I left just a small style note, let me know what you think.
| def load_promotion | ||
| @promotion = Spree::Promotion.find_by(id: params[:id]) || Spree::Promotion.with_coupon_code(params[:id]) | ||
| @promotion = Spree::Promotion.with_coupon_code(params[:id]) | ||
| @promotion ||= Spree::Promotion.find(params[:id]) |
There was a problem hiding this comment.
@SamuelMartini for consistency with what was done after this I would consider using the || here as well, WDYT?
There was a problem hiding this comment.
SamuelMartini
force-pushed
the
SamuelMartini/lean_promotions_controller
branch
from
c5551e2 to
eb481bd
Compare
spaghetticode
approved these changes
Mar 13, 2020
Make it leaner by using the way solidus api has to deal with ActiveRecord::RecordNotFound and authorization. In `load_promotion`, `find_by` is replaced with `find` and the order of the finders is inverted to have the exception as last operator: if a promotion can't be found, raise an exception.
SamuelMartini
force-pushed
the
SamuelMartini/lean_promotions_controller
branch
from
eb481bd to
996a15a
Compare
aldesantis
approved these changes
Mar 26, 2020
|
Thanks @SamuelMartini! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Little change to make
Spree::Api::PromotionsControllerleaner and also consistent with how solidus api deals withActiveRecord::RecordNotFoundand authorization.Checklist: