do not use link_to_add_fields for buttons, its text will be removed from minimize menu #3544
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem:
The link_to_add_fields function will (when used for buttons) create the following markup
<a ...> <span class="text">Add Option Value</span> </a>
The span with class text will be removed when the menu is minimized.
So we only see the plus icon with no text when the menu is minimized.
This happens in the option type edit screen and in the product properties index screen.
/admin/option_types/1/edit
/admin/products/ruby-hoodie/product_properties
See Screenshot:
Solution:
This PR removes the symbols from the buttons just by using link_to instead of link_to_add_fields.
The Buttons will have no more symbol but the text stays when the menu is minimized.
These two where the only buttons with symbols in the Backend.