Add system specs configuration #3552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replicate the feature specs configuration and helpers for system specs.
3 tasks
kennyadsl
reviewed
Mar 13, 2020
There was a problem hiding this comment.
Thanks @blocknotes, I think this works but I'd avoid defining methods in the top level context of the spec_helper. What about moving them into spree/testing_support/ files split by functionality?
Something like:
spree/testing_support/print_missing_translation
spree/testing_support/blacklist_urls
spree/testing_support/prepare_assets_for_browser
This way we can add them safely when needed without duplication, even in stores and extensions. Thoughts?
@kennyadsl: good idea, I have just pushed a commit to isolate the new helpers. |
spaghetticode
approved these changes
Mar 20, 2020
blocknotes
added a commit
to solidusio/solidus_starter_frontend
that referenced
this pull request
Apr 10, 2020
From version 2.11 the systems specs option will be included. PR: `solidusio/solidus#3552`
blocknotes
added a commit
to solidusio/solidus_starter_frontend
that referenced
this pull request
Apr 10, 2020
From version 2.11 the systems specs option will be included. PR: `solidusio/solidus#3552`
blocknotes
added a commit
to solidusio/solidus_starter_frontend
that referenced
this pull request
Apr 10, 2020
From version 2.11 the systems specs option will be included. PR: `solidusio/solidus#3552`
blocknotes
added a commit
to solidusio/solidus_starter_frontend
that referenced
this pull request
Apr 10, 2020
From version 2.11 the systems specs option will be included. PR: `solidusio/solidus#3552`
blocknotes
added a commit
to solidusio/solidus_starter_frontend
that referenced
this pull request
May 25, 2020
From version 2.11 the systems specs option will be included. PR: `solidusio/solidus#3552`
blocknotes
added a commit
to solidusio/solidus_starter_frontend
that referenced
this pull request
May 25, 2020
From version 2.11 the systems specs option will be included. PR: `solidusio/solidus#3552`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replicate the feature specs configuration and helpers for system specs.
Adding system specs support can be a good enhancement for extensions mainly.
Checklist: