DRY paranoia and discard inclusion into models #3555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, I think we still have some occurrences of the newly deprecated methods, can you take a look at failing specs? 🙏 |
|
Ah, I missed that paranoia itself is also using (see here) the newly deprecated scopes ( |
Extract soft delete gems (paranoia and discard) inclusion from models into a reusable concern.
Paranoia is being replaced with Discard. This deprecates with_deleted and only_deleted Paranoia' scopes. This also refactors/remove unnecessary #really_destroy! paranoia method calls which depend on with_deleted scope, hence raises deprecation warnings.
kennyadsl
added
Code Review Needed
changelog:solidus_core
DanielePalombo
approved these changes
Mar 25, 2020
gmacdougall
approved these changes
Mar 25, 2020
|
@cedum this should now be good to merge. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR DRYs the soft delete inclusion logic into a reusable concern.
This also deprecates
.with_deletedand.only_deletedParanoia' scopes, which will be removed in Solidus v3.This has been extracted from the #3488 PR. After some feedback, I'm extracting the non-breaking bits into separate PRs, so we can merge them without having to wait for Solidus v3.
Once merged, I'll rebase and revisit #3488 to definitely remove Paranoia as a dependency from Solidus v3.
Checklist: