-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for prefill user address in new order #3558
Add support for prefill user address in new order #3558
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jaimelr and @JuanCrg90!
I left some comments and I think we should also add some feature specs for this. 🙏
568abad
to
03190a0
Compare
03190a0
to
cc8acbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a possible improvement so we can avoid passing the user to the order_params
method. Thanks!
cc8acbc
to
6c03d86
Compare
When a new order is created passing a user id we want the address to be prefilled. This associate the user address (both ship and bill) by passing the bill_address and ship_address to the `Spree::Core::Importer::Order` via order_params. Co-authored-by: Juan C. Ruiz <[email protected]>
6c03d86
to
a3664d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice. Thanks
Description
Ref #3537
When a new order is created passing a user id we want the address to be prefilled.
This associate the user address (both ship and bill) with the order using
update
Checklist: