Show v2.10 install instructions along with new ones #3562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the last version released on RubyGems is 2.10, but instructions provided in the README only works with master and will be available with 2.11. This commit creates two separate sections in the README that address the two different paths.
This changed in master but the latest released gem still has the old install method.
|
👍 |
aldesantis
approved these changes
Mar 20, 2020
There was a problem hiding this comment.
Thanks @kennyadsl, this definitely created some confusion and it's good to have it cleared up.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With #3538, we changed the name of the command to install Solidus into a Rails application. This change will be available only starting from the next release (or to who is using solidus master).
This PR re-adds old install instructions both in README and Guides since they are expected by users installing Solidus today.
Checklist: