-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non-existing middleware #3570
Conversation
Am I missing something? This middleware does not exist and therefore cannot be loaded. It should be here, right? https://github.com/solidusio/solidus/tree/master/backend/lib/spree/backend On the other side, the Frontend one is present: https://github.com/solidusio/solidus/tree/master/frontend/lib/spree/frontend/middleware
Hey @coorasse, thanks for this PR. It's quite creepy that we had this middleware call there but the system was not complaining. Which error are you seeing exactly? |
I can create a gist later if needed. |
Does it happen when you start the rails server on your own host application? And, are you requiring the main |
Individual subcomponents.
? |
|
Probably unrelated, there's no need to mount backend routes manually. They are injected into the This makes me think that maybe we never call |
Am I missing something? This middleware does not exist and therefore cannot be loaded.
It should be here, right? https://github.com/solidusio/solidus/tree/master/backend/lib/spree/backend
On the other side, the Frontend one is present: https://github.com/solidusio/solidus/tree/master/frontend/lib/spree/frontend/middleware
This instruction makes the installation of solidus_backend fail. 😢