Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix api checkout flow documentation #3575

Merged

Conversation

SamuelMartini
Copy link
Contributor

@SamuelMartini SamuelMartini commented Apr 3, 2020

Description
The Shipment resource is only accessible by an admin user and cannot be directly accessed by a user with no admin role.

The shipments and related rates are returned in the orders json.
To access the order shipments, users with no admin role should GET orders/:order_number or /orders/current and fetch the shipment rates attributes from the body.

Checklist:

The `Shipment` resource is only accessible by admin user and cannot be directly
accessed by a user with no admin role.

The shipments and related rates are returned in the orders json.
To access the order shipments, users with no admin role should GET
`orders/:order_number` or `/orders/current` and fetch the shipment rates attributes.
When updating with `/checkouts#update` the order is advanced to the next state
if the request is succesful.
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SamuelMartini! ✍️

@kennyadsl kennyadsl merged commit 02ac7a9 into solidusio:master Apr 6, 2020
@kennyadsl kennyadsl deleted the SamuelMartini/fix_checkout_flow_api_doc branch April 6, 2020 15:08
@kennyadsl kennyadsl added changelog:solidus_api Changes to the solidus_api gem Documentation labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_api Changes to the solidus_api gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants