Make Payment#gateway_order_id public #3583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method, although in Solidus codebase is currently called only by the class that defines it, can be useful in other scenarios (for example when one wants to use it outside the standard Solidus payment creation flow) so it should be public. Also, it represents information that is not consumed only inside the Spree::Payment model, but ends up stored externally on the payment provider backend.
kennyadsl
approved these changes
Apr 11, 2020
aldesantis
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method, although in Solidus codebase is currently called only by the class that defines it, can be useful in other scenarios (for example when one wants to use it outside the standard Solidus payment creation flow) so it should be public.
Also, it represents information that is not consumed only inside the
Spree::Paymentmodel, but ends up stored externally on the payment provider backend.Checklist: