Refactoring Admin::ProductsController to use ResourcesController#update #3603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldesantis
requested changes
May 4, 2020
| render action: 'edit' | ||
| end | ||
|
|
||
| def check_if_updating_variant_property_rules |
There was a problem hiding this comment.
This doesn't look like this is a check, it seems more like a normalization? Perhaps a better name for this method would be something like normalize_variant_property_rules?
It takes advantage of all validations and error handling that ResourcesController already does, it looks like the code was just copied and added a bit that could have been handled with before action and resources controller callbacks.
softr8
force-pushed
the
refactor-admin-products-controller
branch
from
7c2ccf2 to
969676f
Compare
kennyadsl
added
Important Change
changelog:solidus_backend
aldesantis
approved these changes
May 6, 2020
|
Looking good, thanks @softr8! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It takes advantage of all validations and error handling that
ResourcesController already does, it looks like the code was
just copied and added a bit that could have been handled with
before action and resources controller callbacks.
Checklist: