Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set canceled_at date when canceling an order with cancel (issue #3608) #3610

Merged
merged 1 commit into from
May 13, 2020
Merged

Set canceled_at date when canceling an order with cancel (issue #3608) #3610

merged 1 commit into from
May 13, 2020

Conversation

gugaiz
Copy link
Contributor

@gugaiz gugaiz commented May 7, 2020

Description
Set canceled_at field on the order when calling order.cancel or order.cancel!
Ref issue #3608

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@gugaiz gugaiz force-pushed the fix-canceled_at-issue branch from 65ffa6b to e58422c Compare May 7, 2020 13:32
kennyadsl
kennyadsl reviewed May 8, 2020
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks! Can you please just update the commit message with something meaningful (like the PR title for example)?

@gugaiz gugaiz force-pushed the fix-canceled_at-issue branch from e58422c to ba2947d Compare May 9, 2020 17:16
kennyadsl
kennyadsl approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aldesantis
Copy link
Member

Thanks @gugaiz!

@aldesantis aldesantis merged commit 360ef72 into solidusio:master May 13, 2020
@seand7565 seand7565 mentioned this pull request May 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@jarednorman jarednorman jarednorman approved these changes

@aldesantis aldesantis aldesantis approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gugaiz @aldesantis @kennyadsl @jarednorman @houndci-bot