Always set ActiveStorage::Current.host in base controllers #3613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filippoliverani
force-pushed
the
filippoliverani/simplify-active-storage-checks
branch
from
71c53c8 to
270cd53
Compare
|
@softr8 do you think this is ok to fix your issue? |
Yes! |
kennyadsl
approved these changes
May 14, 2020
There was a problem hiding this comment.
Thanks @filippoliverani! And thanks @softr8 for reporting!
🎉
filippoliverani
force-pushed
the
filippoliverani/simplify-active-storage-checks
branch
from
270cd53 to
8e67e75
Compare
filippoliverani
changed the title
filippoliverani
force-pushed
the
filippoliverani/simplify-active-storage-checks
branch
from
8e67e75 to
1e17f12
Compare
ActiveStorage disk service needs current host to be correctly set. ActiveStorage::SetCurrent concern is not availabile in Rails < 6.0 so we need a custom one. The concern should always be included in in controllers, there's no need to check if we are currently using ActiveStorage based attachment adapters since Solidus already loads ActiveStorage by default. This way we avoid loading uneccessary modules during initialization process that could potentially conflict with custom attachment adapters.
filippoliverani
force-pushed
the
filippoliverani/simplify-active-storage-checks
branch
from
1e17f12 to
89be98c
Compare
filippoliverani
changed the title
aldesantis
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref #3606
ActiveStoragedisk service needs current host to be correctly set.ActiveStorage::SetCurrentconcern is not availabile in Rails < 6.0so we need a custom one. The concern should always be included in
in controllers, there's no need to check if we are currently using
ActiveStoragebased attachment adapters since Solidus already loadsActiveStorageby default. This way we avoid loading uneccessary modulesduring initialization process that could potentially conflict with
custom attachment adapters.
Checklist:
[ ] I have updated Guides and README accordingly to this change (if needed)[ ] I have added tests to cover this change (if needed)[ ] I have attached screenshots to this PR for visual changes (if needed)