Added select on product's scopes for price sorting #3620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
reviewed
May 14, 2020
There was a problem hiding this comment.
Hey @thomasrossetto, thanks for your contribution! 👋
I left a comment and I think it makes sense to also add a spec for this scope here, taking advantage of this change. I'm just afraid that this Postgres fix could break the same query on MySQL (even if I don't think it will happen). With a spec, the CI will take care of run it with both databases.
houndci-bot
reviewed
May 15, 2020
|
@kennyadsl Added test + commented intentionally the right logic. Now you can see postgresql and (maybe) mysql problems. |
jarednorman
reviewed
May 15, 2020
thomasrossetto
force-pushed
the
fix_product_sort_with_postgresql
branch
from
638f8f9 to
0c377f6
Compare
aldesantis
requested changes
May 22, 2020
There was a problem hiding this comment.
@thomasrossetto thanks, just a couple of comments on the spec description format!
thomasrossetto
force-pushed
the
fix_product_sort_with_postgresql
branch
from
0c377f6 to
2d3b3cc
Compare
aldesantis
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
You can find all details here