Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate stoplight doc on version with multiple digits #3632

Conversation

kennyadsl
Copy link
Member

Same as #3631, but on master.

Right now the persist_version job is not triggered since the
regex only take into account versions with one digit after the
decimal point. The regex actually matches but CircleCi needs it
to match the entire string, from their doc:

> Both only and ignore lists can have full names and regular expressions.
> Regular expressions must match the entire string.

https://circleci.com/docs/2.0/configuration-reference/#branches
@kennyadsl kennyadsl self-assigned this May 21, 2020
@aldesantis aldesantis merged commit bf6bdb9 into solidusio:master May 22, 2020
@aldesantis aldesantis deleted the kennyadsl/fix-doc-generation-multiple-digits-master branch May 22, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants