Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused XHR code #3642

Merged
merged 1 commit into from
May 29, 2020
Merged

Remove unused XHR code #3642

merged 1 commit into from
May 29, 2020

Conversation

halilim
Copy link

@halilim halilim commented May 27, 2020

Description
It appears unused. If it is/was, it fails with uninitialized constant Spree::Admin::UsersController::LIKE. The constant LIKE was removed in fe77e9c but it looks like there was another place after all :)

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

Remove unused XHR code
73a8990 
When manually called, fails with `uninitialized constant Spree::Admin::UsersController::LIKE`.
kennyadsl
kennyadsl approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

jarednorman
jarednorman approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@spaghetticode spaghetticode merged commit ce02e8c into solidusio:master May 29, 2020
@halilim halilim deleted the remove-unused-xhr branch May 29, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarednorman jarednorman jarednorman approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@halilim @kennyadsl @jarednorman @spaghetticode