Fix bug related to free shipping not being applied correctly #3671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contexts usually refer to when something changes in the test environment that effects the outcome of the test. I don't think we should have been using context here and describe is a more common pattern imo.
spaghetticode
approved these changes
Jun 19, 2020
There was a problem hiding this comment.
Thanks @jacquesporveau 🎉
I left 2 small comments on the spec context descriptions, but in general this looks good to me 👍
jarednorman
reviewed
Jun 19, 2020
In cases that an order contained *some* shipments with free shipping applied already then when this method would run again it was possible to get an early return and not correctly apply free shipping.
jacquesporveau
force-pushed
the
jacquesporveau/free-promo-bug
branch
from
08c47bf to
caf8957
Compare
|
Thanks gang. I've addressed the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3664
I would leave a more detailed PR description but the author of #3664 did a really good job in describing the problem at hand and this PR is just a solution for that.
I kind of took a bit of liberty in improving the spec quality. Let me know if you don't like that style or something like that and I can rework it if need be.
Checklist: