Add Refund#perform_response and reintroduce @response ivar #3672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reintroduces the instance variable
@response
inSpree::Refund#perform!
that was recently removed in #3641.There may be stores or extensions that rely on the existence of this ivar, so it was reintroduced
but deprecated in favor of the instance method
#perform_response
which has a more appropriate name.There are instances when we need to be able to access the payment gateway response received during the refund perform process, notably in core/app/models/spree/payment/cancellation.rb:31 where it assumes that
#try_void
returns the gateway response:the next line calls core/app/models/spree/payment/processing.rb:191 which makes super clear that we're expecting an object that responds to
#success?
and#authorization
, ie. the gateway response:Checklist: