[Admin] Add filter feature for stock movements #3680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 23, 2020
jacquesporveau
force-pushed
the
jacquesporveau/stock_movements_admin_1
branch
from
a7d46b7 to
b21bd28
Compare
jacquesporveau
changed the title
jacquesporveau
force-pushed
the
jacquesporveau/stock_movements_admin_1
branch
from
b21bd28 to
820a5df
Compare
|
This one has been sitting for a bit now. Pinging for reviews. ❤️ |
jarednorman
approved these changes
Jun 30, 2020
aldesantis
approved these changes
Jul 1, 2020
|
Running the CI again since the failure seems unrelated to the changes. |
|
@jacquesporveau can you please rebase with master? This build is failing due to an annoying flaky spec that was fixed recently. After the rebase your build should become green 💚 ... thanks 🙏 |
We've had feedback from folks that being able to search for stock movements related to a variant would be helpful.
jacquesporveau
force-pushed
the
jacquesporveau/stock_movements_admin_1
branch
from
820a5df to
be40742
Compare
|
@spaghetticode I've rebased and there is still a failing check. I think this one has been failing on all PR's for some time now. Let me know if you'd like anything else from me 👍 |
|
@jacquesporveau yes that's expected, the Rails master build is red due to an external dependency issue. Thanks for rebasing 🙏 |
spaghetticode
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#3666
Checklist: