-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preference for phone validation #3685
Add preference for phone validation #3685
Conversation
eda8969
to
75cefe4
Compare
92fe4b3
to
436514d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think most stores are going to want to keep the phone requirement, aren't they? Pretty much every ecommerce experience I've ever used has, if for nothing else then for support purposes. I don't think we should change the default here, though I'm all for making it configurable if that's something people want to configure.
I've had the opposite experience - The stores I've worked with prefer not to collect phone numbers (more fields on checkout -> lower conversion, at least in theory) and personally it's something that I'd prefer not to give out as a consumer, especially if there's no obvious reason for it - it just feels like data collection for the sake of data collection. I'd like Solidus to be less opinionated about what is and isn't required during checkout - IMO anything not immediately necessary to pay for and ship the order should be optional by default. |
436514d
to
4ec462c
Compare
All fair points. I wish we had a way to gather info about what stores needed more generally. I can only speak to the fact that all of the stores we're currently managing (five or so) require phone and will have to change this setting from the new default if we adopt this. It's obviously only an extremely minor inconvenience, but it makes me second-guess whether it's the right call or whether this is going to be a minor inconvenience to quite a lot of stores. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also like to ask less info to users during checkout but I think it's better to keep the old behavior as default without real data to confirm our ideas.
Adds phone number validation preference so users can easily indicate whether or not they want to require phone numbers for addresses. Ref: solidusio#3679
The `require_zipcode?` method does not check for validity, only presence.
4ec462c
to
1768b15
Compare
Description
Adds phone number validation preference so users can easily indicate
whether or not they want to require phone numbers for addresses.
Ref: #3679
Checklist: