Remove CanCanCan custom actions aliases (cont.) #3701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filippoliverani
force-pushed
the
filippoliverani/remove_cancancan_customizations_cont
branch
4 times, most recently
from
dfa025b to
7f37bed
Compare
filippoliverani
force-pushed
the
filippoliverani/remove_cancancan_customizations_cont
branch
from
7f37bed to
2f94238
Compare
spaghetticode
approved these changes
Jul 31, 2020
aldesantis
requested changes
Aug 3, 2020
There was a problem hiding this comment.
@filippoliverani thanks! Just left one small comment about a typo. I'm also wondering if we should add a deprecation warning for accessible_by calls?
filippoliverani
force-pushed
the
filippoliverani/remove_cancancan_customizations_cont
branch
from
2f94238 to
2bac604
Compare
houndci-bot
reviewed
Aug 21, 2020
filippoliverani
force-pushed
the
filippoliverani/remove_cancancan_customizations_cont
branch
from
2bac604 to
d114b81
Compare
Right, |
Legacy custom action aliases are translated to CanCanCan default aliases. A deprecation warning is raised every time a legacy custom alias is used. A warning is raised every time :read alias is used since its behavior had been customized (:show, :to => :read) and it's different from default CanCanCan behavior (index, :show, :to => :read).
filippoliverani
force-pushed
the
filippoliverani/remove_cancancan_customizations_cont
branch
from
d114b81 to
c92e13a
Compare
4 tasks
kennyadsl
approved these changes
Sep 8, 2020
There was a problem hiding this comment.
Great change @filippoliverani! @coorasse do you have some time to leave your opinion here?
jarednorman
approved these changes
Sep 9, 2020
aldesantis
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a continuation of #3148
Current Solidus' CanCanCan custom action aliases are not needed anymore and can make maintaining permissions and upgrading to new versions of CanCanCan much harder.
This PR:
The new
use_custom_cancancan_actionspreference can be set tofalseto ignore legacy custom aliases and to apply CanCanCan default aliases.If
use_custom_cancancan_actionsis set totrue(default value for existing stores)::readalias is used since its behavior had been customized (:show, :to => :read) and it's different from default CanCanCan behavior (index, :show, :to => :read).Checklist:
[ ] I have updated Guides and README accordingly to this change (if needed)[ ] I have added tests to cover this change (if needed)[ ] I have attached screenshots to this PR for visual changes (if needed)