Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to true/false to yes/no in Auto Capture Select Text #3703

Conversation

michaelmichael
Copy link
Contributor

Description
Ref #3697

This modifies the text in the Auto Capture dropdown menu to make the verbiage more consistent. It checks whether Spree::Config.auto_capture is set to true or false. If it is set to true, the primary dropdown will read "Use App Default (Yes)". If it is set to "false"—or if it is not set (the default config state)—it will read "Use App Default (No)".

Spree::Config.auto_capture = true:
Screen Shot 2020-07-10 at 4 38 30 PM

Spree::Config.auto_capture = false:
Screen Shot 2020-07-10 at 4 39 07 PM

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I'd be open to an attempt to make this a bit easier to read. There's a lot going on on this line.

@aldesantis
Copy link
Member

Looks good and I agree with @jarednorman. @michaelmichael perhaps you can just put the arguments on different lines? I think that alone would make them easier to parse. 🙏

@kennyadsl
Copy link
Member

@michaelmichael let us know if you have time to make the suggested improvements, even in another PR so we can go ahead merging this. Thanks a lot for your contributions!

@michaelmichael michaelmichael force-pushed the use-yes-no-for-auto-capture-defaults branch from 759cb3c to 175e69c Compare July 14, 2020 20:35
@kennyadsl kennyadsl merged commit 57ea33f into solidusio:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants