Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show a deprecation message for PaymentMethod::DISPLAY #3716

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Show a deprecation message for PaymentMethod::DISPLAY #3716

merged 1 commit into from
Jul 31, 2020

Conversation

cedum
Copy link
Contributor

@cedum cedum commented Jul 17, 2020 •
edited
Loading

Spree::PaymentMethod::DISPLAY was deprecated in aaed1ec but a deprecation message was never added afterwards.
This adds a deprecation message on the first call of Spree::PaymentMethod::DISPLAY constant.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@cedum
Show a deprecation message for PaymentMethod::DISPLAY
67f0392 
Spree::PaymentMethod::DISPLAY was deprecated with the  commit
aaed1ec
but a deprecation message was never added.
@cedum cedum force-pushed the deprecate-payment-method-display branch from 90a8a61 to 67f0392 Compare July 17, 2020 15:09
spaghetticode
spaghetticode approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cedum thanks for catching this 👍

@spaghetticode spaghetticode merged commit 48f6717 into solidusio:master Jul 31, 2020
@spaghetticode spaghetticode deleted the deprecate-payment-method-display branch July 31, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarednorman jarednorman jarednorman approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cedum @spaghetticode @jarednorman