-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add payment method selection to the install generator #3731
Add payment method selection to the install generator #3731
Conversation
Will be easier for terminals and editors to parse it and make it clickable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
available_methods = PAYMENT_METHODS.keys | ||
|
||
payment_method_name = ask(" | ||
You can now select a payment method to be included in the installation process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would drop the now
. For sure it's a novelty at the moment of writing, but it won't be for long 📆
|
||
payment_method_name = ask(" | ||
You can now select a payment method to be included in the installation process. | ||
Please select a payment method name?", limited_to: available_methods, default: available_methods.first) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please select a payment method name?
-> the question mark in this sentence seems a bit odd to me, what about removing it or changing the wording?
73e6736
to
b3c1ab2
Compare
Defaults to paypal commerce platform, additional methods can be added in the future.
The option is true by default and should still be true for empty or bad input.
b3c1ab2
to
e5e6d30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elia thank you 👍
Description
This improves the install generator making the final result better equipped for production use.
The default payment method is PayPal Commerce Platform that has a convenient no-code-required onboarding process. New methods can be added easily for similar solutions, which are encouraged.
Checklist:
Preview
help banner: