Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade acts_as_list gem dependency to allow v1.x #3736

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Upgrade acts_as_list gem dependency to allow v1.x #3736

merged 1 commit into from
Aug 26, 2020

Conversation

marcrohloff
Copy link
Contributor

Description
Updates the acts_as_list gem dependency for solidus-core from ~0.3 (which matches up to v0.9.19) to < 2.0
(the current acts_as_list version is 1.0 released 2019-09-26)

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only dangerous thing I can see in the acts_as_list CHANGELOG is dropping support for older Rails versions that we are not supporting anyway. 👍 Thank you!

@kennyadsl kennyadsl merged commit 3dc4504 into solidusio:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants