Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The install generator is no longer using Bundler::CLI #3739

Merged
merged 1 commit into from
Aug 24, 2020
Merged

The install generator is no longer using Bundler::CLI #3739

merged 1 commit into from
Aug 24, 2020

Conversation

elia
Copy link
Member

@elia elia commented Aug 21, 2020

Description

It was introduced to support this call to Bundler::CLI that is no
longer there:

89da654#diff-fee8174dbde028e2b7b26051c26aff79R169-R172

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@elia
The install generator is no longer using Bundler::CLI
ca331ef 
It was introduced to support this call to Bundler::CLI that is no
longer there:

solidusio@89da654#diff-fee8174dbde028e2b7b26051c26aff79R169-R172
@aldesantis aldesantis merged commit 7c1f2e6 into solidusio:master Aug 24, 2020
@aldesantis aldesantis deleted the elia/remove-useless-requires branch August 24, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarednorman jarednorman jarednorman approved these changes

@aldesantis aldesantis aldesantis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elia @aldesantis @jarednorman