Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set payment method to none #3751

Merged

Conversation

peterberkenbosch
Copy link
Contributor

@peterberkenbosch peterberkenbosch commented Aug 31, 2020

Description
By default Solidus is now looking for solidus_paypal_commerce_platform,
however, with the sandbox and the dummy generator we need to set this
to none, otherwise these scripts are not running successfully.

This commit fixes that. It does not update the application template for Heroku
though. That will be a seperate PR.

Ref #3750 #3748 #3744

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

By default Solidus is now looking for `solidus_paypal_commerce_platform`,
however, with the sandbox and the dummy generator we need to set this
to `none`, otherwise these scripts are not running successfully.

This commit fixes that. It does not update the application template for Heroku
though. That will be a seperate PR.
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@aldesantis aldesantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jarednorman jarednorman merged commit d88fff7 into solidusio:master Aug 31, 2020
MinasMazar pushed a commit to solidusio-contrib/solidus_importer that referenced this pull request Sep 1, 2020
via `solidus extension .`

otherwise sandbox commands returns

        Could not find gem 'solidus_paypal_commerce_platform' in any of the gem sources listed in your Gemfile.
        Run `bundle install` to install missing gems.

Ref. solidusio/solidus#3751
MinasMazar pushed a commit to solidusio-contrib/solidus_importer that referenced this pull request Sep 1, 2020
via `solidus extension .`

otherwise sandbox commands returns

        Could not find gem 'solidus_paypal_commerce_platform' in any of the gem sources listed in your Gemfile.
        Run `bundle install` to install missing gems.

Ref. solidusio/solidus#3751
MinasMazar pushed a commit to solidusio-contrib/solidus_importer that referenced this pull request Sep 1, 2020
via `solidus extension .`

otherwise sandbox commands returns

        Could not find gem 'solidus_paypal_commerce_platform' in any of the gem sources listed in your Gemfile.
        Run `bundle install` to install missing gems.

Ref. solidusio/solidus#3751
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants