-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set payment method to none #3751
Merged
jarednorman
merged 1 commit into
solidusio:master
from
peterberkenbosch:payment-method-none-by-default
Aug 31, 2020
Merged
Set payment method to none #3751
jarednorman
merged 1 commit into
solidusio:master
from
peterberkenbosch:payment-method-none-by-default
Aug 31, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default Solidus is now looking for `solidus_paypal_commerce_platform`, however, with the sandbox and the dummy generator we need to set this to `none`, otherwise these scripts are not running successfully. This commit fixes that. It does not update the application template for Heroku though. That will be a seperate PR.
kennyadsl
approved these changes
Aug 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
aldesantis
approved these changes
Aug 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @peterberkenbosch!
jarednorman
approved these changes
Aug 31, 2020
MinasMazar
pushed a commit
to solidusio-contrib/solidus_importer
that referenced
this pull request
Sep 1, 2020
via `solidus extension .` otherwise sandbox commands returns Could not find gem 'solidus_paypal_commerce_platform' in any of the gem sources listed in your Gemfile. Run `bundle install` to install missing gems. Ref. solidusio/solidus#3751
MinasMazar
pushed a commit
to solidusio-contrib/solidus_importer
that referenced
this pull request
Sep 1, 2020
via `solidus extension .` otherwise sandbox commands returns Could not find gem 'solidus_paypal_commerce_platform' in any of the gem sources listed in your Gemfile. Run `bundle install` to install missing gems. Ref. solidusio/solidus#3751
MinasMazar
pushed a commit
to solidusio-contrib/solidus_importer
that referenced
this pull request
Sep 1, 2020
via `solidus extension .` otherwise sandbox commands returns Could not find gem 'solidus_paypal_commerce_platform' in any of the gem sources listed in your Gemfile. Run `bundle install` to install missing gems. Ref. solidusio/solidus#3751
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default Solidus is now looking for
solidus_paypal_commerce_platform
,however, with the sandbox and the dummy generator we need to set this
to
none
, otherwise these scripts are not running successfully.This commit fixes that. It does not update the application template for Heroku
though. That will be a seperate PR.
Ref #3750 #3748 #3744
Checklist: