Expose js function: Spree.SortableTable.refresh

[brunoao86]

Description

The sortable table component is only loaded once when page is loaded.
So it will be very useful to be called after asynchronous requests.

The behaviour stays the same, but now we'll have a function available to refresh the sortable table component if needed by calling Spree.SortableTable.refresh() in the javascript.

Motivation

I'm adding sortable table component on Product / Parts and this exposing was needed.
solidusio-contrib/solidus_product_assembly#92

Checklist:

• I have followed Pull Request guidelines
• I have added a detailed description into each commit message
• I have updated Guides and README accordingly to this change (if needed)
• I have added tests to cover this change (if needed)
• I have attached screenshots to this PR for visual changes (if needed)

[spaghetticode]

@brunoao86 I think this is a useful improvement, thanks for working on it!

I am not 100% sure about the proposed interface Spree.refresh_sortable_tables: I think that it would be better to avoid attaching functions (at least very specific ones) to the global Spree namespace... I would feel more comfortable with something like Spree.SortableTable.refresh(). What do you think?

[brunoao86]

@brunoao86 I think this is a useful improvement, thanks for working on it!

I am not 100% sure about the proposed interface Spree.refresh_sortable_tables: I think that it would be better to avoid attaching functions (at least very specific ones) to the global Spree namespace... I would feel more comfortable with something like Spree.SortableTable.refresh(). What do you think?

Thanks for the review, @spaghetticode! It makes total sense, I will work on that!

[brunoao86]

@brunoao86 I think this is a useful improvement, thanks for working on it!

I am not 100% sure about the proposed interface Spree.refresh_sortable_tables: I think that it would be better to avoid attaching functions (at least very specific ones) to the global Spree namespace... I would feel more comfortable with something like Spree.SortableTable.refresh(). What do you think?

Hey @spaghetticode! ✌️
Hope all is well.

When you have some free time, can you please review this PR again?
I applied your suggestion on this commit fb4f841

Thanks again! 🙏

[spaghetticode]

Looks good, can you please squash the commits into a single one? thanks

approved by mistake

[spaghetticode]

@brunoao86 sorry, I just realized the changes are scattered in 3 commits. Can you squash them into a single one, with a good commit message? thanks 🙏

[brunoao86]

Hey @spaghetticode

It is done! ✔️

Is there a way to do the squash without the force-pushed? I just did that when merging the code so I don't know if I did it right.

Thanks! 🙏

[spaghetticode]

@brunoao86 push -f is ok 👍
Again, thanks for this contribution 🎉

[aldesantis]

Thanks @brunoao86!