Make admin order event_links translatable #3772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tvdeyen I think the failing specs are related to the change but it probably just needs a capitalization. |
tvdeyen
force-pushed
the
fix-event_links-translations
branch
from
ba2963c to
089cd88
Compare
|
@kennyadsl yes, will fix them soon |
The admin/orders_helper event_links didn't had enough scope to be translatable for the particular order event. In some languages canceling and order is something different than clicking a "cancel" button in a form. The solidus_i18n gem already has the translation scopes for these events, so I implemeted it that it will Just Work™
tvdeyen
force-pushed
the
fix-event_links-translations
branch
from
089cd88 to
0ce33ec
Compare
|
@kennyadsl should now be fixed |
aldesantis
approved these changes
Sep 26, 2020
There was a problem hiding this comment.
@tvdeyen thanks, looking great. Left a non-blocking comment but I'm going to approve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The admin/orders_helper event_links didn't had enough scope to be translatable for the particular order event. In some languages canceling and order is something different than clicking a "cancel" button in a form.
The solidus_i18n gem already has the translation scopes for these events, so I implemeted it that it will Just Work™
Checklist: