Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace with :all_adjustments.nonzero.any? #3787

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Replace with :all_adjustments.nonzero.any? #3787

merged 1 commit into from
Oct 5, 2020

Conversation

duartemvix
Copy link
Contributor

@duartemvix duartemvix commented Oct 4, 2020

#3782

A previous pull request was closed before I could force-push a few necessary changes and I reopened this one.

Replace with all_adjustments.nonzero.any? and reduce requests to database from 3 to 1.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes sense.

@kennyadsl kennyadsl added the changelog:solidus_frontend Changes to the solidus_frontend gem label Oct 5, 2020
@jarednorman jarednorman merged commit b759bd0 into solidusio:master Oct 5, 2020
@jarednorman
Copy link
Member

Thanks!

@duartemvix duartemvix deleted the adjustments branch October 6, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_frontend Changes to the solidus_frontend gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants