Improve the developer experience with the new Ability deprecations #3801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The :read action generates a deprecation for end users that can't be solved from within the application.
This change will target the actual line that called #can? instead of the line in which the deprecation was issued (i.e. ability.rb:44).
elia
force-pushed
the
elia/ability-deprecations-fixes
branch
from
1d6b9e8 to
deaba24
Compare
houndci-bot
reviewed
Oct 23, 2020
The wording and rendering of action names is more consistent and adds clear directions about what needs to be done to fix the issue.
The standard name is actually :destroy, and the custom one :delete.
elia
force-pushed
the
elia/ability-deprecations-fixes
branch
from
deaba24 to
915ffa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the
:readability is used in many places that trigger the deprecation without leaving the dev a chance to fix it.It also points to the line in which the warning is issued instead of the line calling
#can?.This PR fixes both problems.
Checklist: