Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove seeds for images associated to master variant #3805

Merged

Conversation

aleph1ow
Copy link
Contributor

@aleph1ow aleph1ow commented Oct 23, 2020

Description

Removes seeds associated with the master variant of the following products:

  • solidus_tshirt
  • solidus_long
  • solidus_girly

This is in order to simply not show the product images in the thumbnail list of each variant because they are not related to the variant color itself.

Before After
Screenshot 2020-10-23 at 11 31 03 Screenshot 2020-10-23 at 11 31 23

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

Removes seeds associated with the master variant of the following products:
- solidus_tshirt
- solidus_long
- solidus_girly
@aleph1ow aleph1ow force-pushed the aleph1ow/remove-product-images-seeds branch from d38999f to 865afaa Compare October 23, 2020 09:36
@kennyadsl kennyadsl merged commit 3e49459 into solidusio:master Nov 17, 2020
@kennyadsl kennyadsl deleted the aleph1ow/remove-product-images-seeds branch November 17, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants