Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix headers in changelog #3812

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Conversation

jarednorman
Copy link
Member

Description

I noticed this on my stream last Friday: the headers contained non-breaking spaces instead of regular spaces so GitHub wasn't formatting them as headers in the UI.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

Can you spot the difference? These headers weren't showing up right in
the GitHub UI because the spaces were actually non-breaking spaces, so
these weren't interpreted as markdown level-3 headers.
@jarednorman jarednorman merged commit bcef2ea into solidusio:master Oct 29, 2020
@jarednorman jarednorman deleted the fix-nbsp branch October 29, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants