Remove all code deprecated in Solidus v2.x #3818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
force-pushed
the
kennyadsl/remove-all-deprecations
branch
from
ff9c686 to
e8da891
Compare
houndci-bot
reviewed
Oct 30, 2020
DanielePalombo
force-pushed
the
kennyadsl/remove-all-deprecations
branch
from
3f98930 to
cf293a6
Compare
kennyadsl
force-pushed
the
kennyadsl/remove-all-deprecations
branch
6 times, most recently
from
bae6330 to
c79faaf
Compare
houndci-bot
reviewed
Nov 5, 2020
kennyadsl
force-pushed
the
kennyadsl/remove-all-deprecations
branch
5 times, most recently
from
dfece2c to
175af5f
Compare
houndci-bot
reviewed
Nov 11, 2020
kennyadsl
force-pushed
the
kennyadsl/remove-all-deprecations
branch
3 times, most recently
from
e1bbf4f to
5a6e786
Compare
DanielePalombo
force-pushed
the
kennyadsl/remove-all-deprecations
branch
from
5af1c25 to
3c2a695
Compare
kennyadsl
commented
Nov 16, 2020
kennyadsl
force-pushed
the
kennyadsl/remove-all-deprecations
branch
4 times, most recently
from
042d20a to
7669852
Compare
`with_adjustments` was deprecated and never used within the whole codebase.
PricingHelper made current_currency helper method available at controller/view level. Spree::Order::Search::Base was alowing to set the currency directly. It now requires using pricing_options
Removes: - `Spree::Config.events.subscribers` in favor of `.subscriber_registry` - meta-generated handlers accessors in `Spree::Event::Subscriber.event_action` - `Spree::Event::Subscriber#subscribe! and #unsubscribe!
Deprecated in favor of Spree::Core::Environment::Promotions.
…uantity and Spree::TestingSupport::CapybaraExt.wait_for_ajax ref solidusio@f8fe5c6 and solidusio@80abce4
All the tasks in this file are deprecated ref solidusio#2080
This commit removes all the spree_get, spree_post, etc. methods that we deprecated a while ago. We are now using plain get, post, etc. from RSpec.
The new suggested approach of setting preference is stubbing them so there's no need to reset preferences anymore.
They are not raised anymore. This commit also refactor that specific piece a little bit.
I also add the require of `active_support` on core/lib/spree/core/class_constantized.rb because it's required to use the delegate method https://github.com/solidusio/solidus/blame/33821050ad299640ea31d104a59dd38bcd97ae2a/core/lib/spree/core/class_constantizer.rb#L25
It is now bin/sandbox
Use pathFor now!
Spree::Calculator::FreeShipping Spree::Calculator::PercentPerItem Spree::Caluclator::PriceSack These class were present in the codebase but not available anywhere in the admin since they are not added in the array of available calculators in app_configuration.rb.
The _deprecated_variables.scss file is empty now but I think we can keep it to create a standard to deprecate scss variables.
in favor of .pill-
kennyadsl
force-pushed
the
kennyadsl/remove-all-deprecations
branch
from
90afece to
5e3b610
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3816
Now that master points to Solidus 3.0, we can remove all code deprecated in Solidus 2.x and introduce the breaking changes of this major.
Removals without deprecation
Spree::LineItem::CurrencyMismatchexception: we are not using it anymore since the behavior we had withSpree::Config.raise_with_invalid_currency = truehas been removed.Spree::Order::Checkoutis not used anymore.Spree::Admin::PaymentsHelperis not used anymore.UserPaymentSourceis empty after removing all deprecated methods inside it.Spree::Refund#perform_after_createattribute, if you are still using it, please stop, it does nothing now.Spree::TaxCalculator#ShippingRate: it is now alwaysnilSpree::Money::RUBY_NUMERIC_STRING: was only used in a deprecated code path.Preferences
We removed the following preferences without deprecations. They were just controlling a deprecated flow and have no effect so, assuming you already switched to the only accepted value, you can safely remove them.
Spree::Config.raise_with_invalid_currencySpree::Config.redirect_back_on_unauthorized preferenceSpree::Config.run_order_validations_on_order_updater preferenceSpree::Config.use_legacy_order_state_machineSpree::Config.use_legacy_store_credit_reimbursement_category_nameSpree::Config.consider_actionless_promotion_activeSpree::Config.use_legacy_address_state_validator(removed in Remove legacy address state validation logic #3847)Spree::Config.use_combined_first_and_last_name_in_address(removed in Remove deprecated name-related Address fields #3820)