Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Solidus events documentation #3819

Merged

Conversation

spaghetticode
Copy link
Member

Description

Solidus internal events were not showing properly.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)


Another way to subscribe to events is creating a "subscriber" module that
includes the `Spree::Event::Subscriber` module. For example:
You can subscribe to events also by creating a "subscriber" module that includes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "You can also subscribe to events by creating a "subscriber" module".

@kennyadsl kennyadsl added this to the 3.1.0 milestone Nov 5, 2020
@spaghetticode spaghetticode force-pushed the spaghetticode/improve-events-doc branch from 2aac8ee to b4b3097 Compare November 6, 2020 15:32
Solidus internal events were not showing properly.
@spaghetticode spaghetticode force-pushed the spaghetticode/improve-events-doc branch from b4b3097 to 0dbe861 Compare April 23, 2021 13:00
@spaghetticode spaghetticode merged commit e940e56 into solidusio:master Apr 23, 2021
@spaghetticode spaghetticode deleted the spaghetticode/improve-events-doc branch April 23, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants