Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ability to void invalid payments #3858

Merged
merged 2 commits into from
Dec 14, 2020
Merged

Remove ability to void invalid payments #3858

merged 2 commits into from
Dec 14, 2020

Conversation

vl3
Copy link
Contributor

@vl3 vl3 commented Dec 9, 2020 •
edited
Loading

Description

My reasoning behind this is that attempts to void invalid payments will fail because response_code is not set for invalid payments. There are several things that suggests that transitioning from invalid to void should be forbidden (although that the payment could be reattempted, but that's another story).

So everything suggests that invalid state should be final and, other than reattempting the payment , we should block this transition. Attached is an screenshot of how the admin panel will understand transitions.

Before

invalid_payment_before

After
invalid_payment_after

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

kennyadsl
kennyadsl reviewed Dec 9, 2020
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense, thanks! I left a question about the implementation that I think we can DRY a bit, let me know!

core/app/models/spree/payment_source.rb Outdated Show resolved Hide resolved
@vl3
Remove ability to void invalid payments
f4637c9 
Voiding invalid payments will result in an error due to the lack of
response_code. Additionally, this transition is not allowed in the
payment state machine.
@vl3 vl3 force-pushed the remove_ability_to_void_invalid_payments branch from ff27f7f to f4637c9 Compare December 9, 2020 18:09
@vl3 vl3 requested a review from kennyadsl December 9, 2020 19:24
jarednorman
jarednorman approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

kennyadsl
kennyadsl approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kennyadsl kennyadsl added this to the 3.1.0 milestone Dec 10, 2020
@kennyadsl kennyadsl added release:major Breaking change on hold until next major release Needs Backport and removed release:major Breaking change on hold until next major release labels Dec 10, 2020
@kennyadsl kennyadsl modified the milestones: 3.1.0, 2.11 Dec 10, 2020
@vl3 vl3 mentioned this pull request Dec 10, 2020
Closed
@kennyadsl kennyadsl merged commit ff43626 into solidusio:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarednorman jarednorman jarednorman approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.11
Development

Successfully merging this pull request may close these issues.
3 participants
@vl3 @kennyadsl @jarednorman