Normalize email required checks #3879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
added
the
release:major
|
@elia can you please rebase and undraft this PR when you have a moment? I'd love to have this merged. |
kennyadsl
removed
the
release:major
Across the repo the `<field-name>_required?` format is the most common.
elia
force-pushed
the
elia/normalize-email-required-checks
branch
from
a4849c0 to
8bab13a
Compare
|
@kennyadsl done! ✔️ |
jarednorman
approved these changes
May 3, 2021
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Mar 21, 2023
Please, use Spree::Order#email_required? now. Ref solidusio#3879
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Mar 27, 2023
Please, use Spree::Order#email_required? now. Ref solidusio#3879
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Apr 12, 2023
Please, use Spree::Order#email_required? now. Ref solidusio#3879
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Apr 14, 2023
Please, use Spree::Order#email_required? now. Ref solidusio#3879
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Apr 18, 2023
Please, use Spree::Order#email_required? now. Ref solidusio#3879
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Apr 19, 2023
Please, use Spree::Order#email_required? now. Ref solidusio#3879
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
Apr 24, 2023
Please, use Spree::Order#email_required? now. Ref solidusio#3879
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the same method name for
User#email_required?andOrder#require_email, I picked#email_required?.Checklist: