Only use #original_message in Api::BaseController#parameter_missing_error if defined #3940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, either because of older Rails versions or weird load order bugs, #original_message is not defined for the ParameterMissing error class. As error handling should not raise its own obscuring error, use the #try method to obtain #original_message, if defined.
dividedharmony
changed the title
|
Last week I was working on trying to fix |
kennyadsl
added
Needs Backport
changelog:solidus_api
jarednorman
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on solidusio-contrib/solidus_related_products#88 for solidus_related_products, I came across a bug that has caused every branch on that repository to fail its specs.
Sometimes, for reasons that I don't completely understand, the
ParameterMissingerror class does not define#original_message, causing aNoMethodErrorto be raised, which obscures the original execption and returns a 500 status response.Further background is detailed in #3941
As error handling should not raise its own obscuring error, use the #try method to obtain #original_message, if defined.
Checklist: