Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix circular reference in factory #3959

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Fix circular reference in factory #3959

merged 1 commit into from
Feb 26, 2021

Conversation

waiting-for-dev
Copy link
Contributor

@waiting-for-dev waiting-for-dev commented Feb 25, 2021 •
edited
Loading

This was causing a double in-memory addition of the same line item to an
order.

From the repository root:

gem which factory_bot
bin/rails console

And then, from the console:

$LOAD_PATH << '/lib/directory/for/factory/bot/from/above/'
require_relative '../core/lib/spree/testing_support/factories/order_factory'
order = FactoryBot.create(:order_with_totals)
order.line_items.count # 1
order.line_items.size # 2, before this commit
order.line_items.size # 1, after this commit

Description

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

cc @kennyadsl

@waiting-for-dev
Fix circular reference in factory
2c9da21 
This was causing a double in-memory addition of the same line item to an
order.

From the repository root:

```bash
gem which factory_bot
bin/rails console
```

And then, from the console:

```ruby
$LOAD_PATH << '/lib/directory/for/factory/bot/from/above/'
require_relative '../core/lib/spree/testing_support/factories/order_factory'
order = FactoryBot.create(:order_with_totals)
order.line_items.count # 1
order.line_items.size # 2, before this commit
order.line_items.size # 1, after this commit
```
waiting-for-dev added a commit to solidusio/solidus_starter_frontend that referenced this pull request Feb 25, 2021
@waiting-for-dev
Fix failing tests
45a0cf8 
We were adding another line to match buggy behavior caused by the
circular reference fixed in solidusio/solidus#3959.

Tests will be green once both changes are integrated.
@waiting-for-dev waiting-for-dev mentioned this pull request Feb 25, 2021
Merged
3 tasks
kennyadsl
kennyadsl approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kennyadsl kennyadsl added changelog:solidus_core Changes to the solidus_core gem Needs Backport labels Feb 25, 2021
spaghetticode
spaghetticode approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waiting-for-dev thanks!

@kennyadsl kennyadsl merged commit cff5fc0 into solidusio:master Feb 26, 2021
@kennyadsl kennyadsl deleted the fix_order_totals_factory branch February 26, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarednorman jarednorman jarednorman approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

Assignees
No one assigned
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@waiting-for-dev @spaghetticode @kennyadsl @jarednorman