Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't hack into ActionMailer to add our mail previews path #3961

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Don't hack into ActionMailer to add our mail previews path #3961

merged 1 commit into from
Apr 30, 2021

Conversation

elia
Copy link
Member

@elia elia commented Feb 26, 2021

Description

Instead just append our AM preview path let the app control wether they're enabled or not, without forcing it only on some environments.

From the Rails guides of the versions we support:

The path is used inside a glob, that's why we use the {path1,path2} notation to add the path to the existing one.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)

@elia elia force-pushed the dont-check-env-for-mailer-previews branch 2 times, most recently from f574469 to 9564f14 Compare February 26, 2021 13:15
@elia elia marked this pull request as ready for review February 26, 2021 14:05
@elia
Don't hack into AM to add mail previews
0b30461 
Instead just append our AM preview path let the app control wether
they're enabled or not, without forcing it only on some environments.
@elia elia force-pushed the dont-check-env-for-mailer-previews branch from 9564f14 to 0b30461 Compare February 26, 2021 14:09
@elia elia changed the title Don't hack into AM to add mail previews Don't hack into ActionMailer to add our mail previews path Feb 26, 2021
aldesantis
aldesantis approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@aldesantis aldesantis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elia thanks! Shame on me for not thinking about this when I implemented the original fix.

@kennyadsl kennyadsl added this to the 3.1.0 milestone Mar 5, 2021
@kennyadsl kennyadsl added release:major Breaking change on hold until next major release changelog:solidus_core Changes to the solidus_core gem labels Mar 8, 2021
@kennyadsl kennyadsl merged commit 659999c into solidusio:master Apr 30, 2021
@kennyadsl kennyadsl deleted the dont-check-env-for-mailer-previews branch April 30, 2021 09:11
@kennyadsl kennyadsl removed the release:major Breaking change on hold until next major release label Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@jarednorman jarednorman jarednorman approved these changes

@aldesantis aldesantis aldesantis approved these changes

Assignees
No one assigned
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@elia @aldesantis @jarednorman @houndci-bot @kennyadsl