Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADMIN] Properly format flash error message #3996

Merged
merged 1 commit into from
May 20, 2021
Merged

[ADMIN] Properly format flash error message #3996

merged 1 commit into from
May 20, 2021

Conversation

spaghetticode
Copy link
Member

Description

The previous implementation output was the string representation of an array instead of a properly formatted text.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@spaghetticode
Properly format flash error message
f3b5d76 
The previous implementation output was the string representation
of an array instead of a properly formatted text.
@spaghetticode spaghetticode added the type:bug Error, flaw or fault label Mar 16, 2021
@spaghetticode spaghetticode self-assigned this Mar 16, 2021
@kennyadsl
Copy link
Member

When this has been introduced?

@spaghetticode
Copy link
Member Author

@kennyadsl this is still the original implementation of the method.

@kennyadsl kennyadsl added this to the 3.1.0 milestone Mar 17, 2021
@kennyadsl kennyadsl added the release:major Breaking change on hold until next major release label Mar 17, 2021
@kennyadsl
Copy link
Member

Ok, thanks. I think we can merge this after the 3.0 release. Adjusted Milestone and labels accordingly.

@kennyadsl kennyadsl removed the release:major Breaking change on hold until next major release label Apr 30, 2021
@kennyadsl kennyadsl merged commit b6e24da into solidusio:master May 20, 2021
@kennyadsl kennyadsl deleted the spaghetticode/fix-flash-message branch May 20, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarednorman jarednorman jarednorman approved these changes

@aldesantis aldesantis aldesantis approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees

@spaghetticode spaghetticode

Labels
type:bug Error, flaw or fault
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@spaghetticode @kennyadsl @aldesantis @jarednorman