Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more appropriate language for woman's t-shirt in sample data #4031

Merged

Conversation

Noah-Silvera
Copy link
Contributor

@Noah-Silvera Noah-Silvera commented Apr 20, 2021

Description

In the sample data, a woman's t-shirt exists with the product name "Solidus Girly"

Using the word "girly" to describe a woman's t-shirt is infantilizing, so we should update the product in the sample database to use "woman's " instead.

Manual Tests

  1. Create a Sandbox app
    • Ensure it successfully seeds
    • Ensure the "Solidus Girly" product has been updated to "Solidus Woman's T-Shirt"

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
    - [ ] I have updated Guides and README accordingly to this change (if needed)
    - [ ] I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

Screen Shot 2021-04-20 at 12 32 18PDT

Copy link
Contributor

@peterberkenbosch peterberkenbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out and fix it as well. LGTM! 👍 :shipit:

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just approved but upon further consideration, do you think it should be "Women's" rather than "Woman's", since you wouldn't say "Man's T-Shirt", you'd say "Men's T-Shirt"?

@jarednorman jarednorman dismissed their stale review April 24, 2021 03:29

Fine to merge either way

@Noah-Silvera Noah-Silvera force-pushed the change-solidus-girly-product-name branch from 6322690 to 7c8d6dd Compare April 26, 2021 15:32
@Noah-Silvera
Copy link
Contributor Author

I just approved but upon further consideration, do you think it should be "Women's" rather than "Woman's", since you wouldn't say "Man's T-Shirt", you'd say "Men's T-Shirt"?

Always coming in hot with the grammar catches! Thanks, updated :)

Using girly to describe a women's t-shirt is infantilizing, so we should
update the product in the sample database to use "women's " instead.
@Noah-Silvera Noah-Silvera force-pushed the change-solidus-girly-product-name branch from 7c8d6dd to ea378b5 Compare April 26, 2021 15:33
@jarednorman jarednorman merged commit 2ea8296 into solidusio:master Apr 26, 2021
@Noah-Silvera Noah-Silvera deleted the change-solidus-girly-product-name branch April 26, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants