-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use more appropriate language for woman's t-shirt in sample data #4031
Use more appropriate language for woman's t-shirt in sample data #4031
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing that out and fix it as well. LGTM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just approved but upon further consideration, do you think it should be "Women's" rather than "Woman's", since you wouldn't say "Man's T-Shirt", you'd say "Men's T-Shirt"?
6322690
to
7c8d6dd
Compare
Always coming in hot with the grammar catches! Thanks, updated :) |
Using girly to describe a women's t-shirt is infantilizing, so we should update the product in the sample database to use "women's " instead.
7c8d6dd
to
ea378b5
Compare
Description
In the sample data, a woman's t-shirt exists with the product name "Solidus Girly"
Using the word "girly" to describe a woman's t-shirt is infantilizing, so we should update the product in the sample database to use "woman's " instead.
Manual Tests
Checklist:
- [ ] I have updated Guides and README accordingly to this change (if needed)- [ ] I have added tests to cover this change (if needed)