Review install instructions in README and Guides #4034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpfergus1
reviewed
Apr 21, 2021
| ``` | ||
|
|
||
| [solidus-auth-devise]: https://github.com/solidusio/solidus_auth_devise | ||
|
|
||
| ### Set the administrator username and password | ||
|
|
||
| The `solidus:install` generator prompts you to configure the Solidus administrator |
There was a problem hiding this comment.
I believe we might want to change this to:
The `solidus:install` generator prompts you to configure the default authorization solution, default payment service, and the Solidus administrator
along with the defaults below.
There was a problem hiding this comment.
It's authentication and not authorization but this proposal makes perfect sense, thanks!
cpfergus1
approved these changes
Apr 21, 2021
For the sake of clarity, we can remove the install instructions for Solidus <= 2.10. It's very unlikely that someone will start a new application with that version now.
kennyadsl
force-pushed
the
kennyadsl/update-install-instructions
branch
from
2c5cee2 to
dac3449
Compare
jarednorman
approved these changes
Apr 25, 2021
spaghetticode
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the sake of clarity, we can remove the install instructions for Solidus <= 2.10. It's very unlikely that someone will start a new application with that version now.
TODO: