Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use symbols in polymorphic path for event_links #4048

Merged
merged 2 commits into from
May 7, 2021
Merged

Use symbols in polymorphic path for event_links #4048

merged 2 commits into from
May 7, 2021

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 6, 2021

Description

Rails 6.0.3.7 introduced a security fix, that forces us to use symbols
in polymorphic paths.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change (if needed)

@tvdeyen
Use symbols in polymorphic path for even_links
bc06da5 
Rails 6.0.3.7 introduced a security fix, that forces us to use symbols
in polymorphic paths.
@tvdeyen tvdeyen changed the title Use symbols in polymorphic path for even_links Use symbols in polymorphic path for event_links May 6, 2021
@tvdeyen tvdeyen self-assigned this May 6, 2021
@tvdeyen tvdeyen marked this pull request as draft May 6, 2021 13:12
@tvdeyen
Use symbol for parent_model_name in resource controller
1f089e3 
Rails does not allow Strings in polymorphic urls anymore for security
reasons.
@tvdeyen tvdeyen marked this pull request as ready for review May 6, 2021 13:24
@tvdeyen tvdeyen requested a review from a team May 6, 2021 13:38
kennyadsl
kennyadsl approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tvdeyen! We need to backport this in 3.0, 2.11 and 2.10 as well.

@kennyadsl kennyadsl added Needs Backport changelog:solidus_core Changes to the solidus_core gem labels May 6, 2021
spaghetticode
spaghetticode approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tvdeyen thanks!

benjaminwil added a commit to SuperGoodSoft/solidus that referenced this pull request May 6, 2021
@benjaminwil
Use symbols in polymorphic path for event links
920fc2a 
This change is backported from a recent Solidus pull request. This is
required for `solidus_backend` 2.8 to run on Rails v5.2.6.

See solidusio#4048 for more information.
@waiting-for-dev waiting-for-dev mentioned this pull request May 7, 2021
Merged
5 tasks
@tvdeyen tvdeyen merged commit 7cd6c4d into solidusio:master May 7, 2021
@tvdeyen tvdeyen deleted the fix-polymorphic-path-strings branch May 7, 2021 07:06
@tvdeyen
Copy link
Member Author

tvdeyen commented May 7, 2021

I will create another PR to v2.11

@tvdeyen tvdeyen mentioned this pull request May 7, 2021
Merged
3 tasks
@benjaminwil benjaminwil mentioned this pull request May 8, 2021
Closed
This was referenced Dec 2, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarednorman jarednorman jarednorman approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

Assignees

@tvdeyen tvdeyen

Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tvdeyen @spaghetticode @kennyadsl @jarednorman