Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix customer return validation for return items without inventory units #4068

Merged
merged 1 commit into from
May 21, 2021
Merged

Fix customer return validation for return items without inventory units #4068

merged 1 commit into from
May 21, 2021

Conversation

willianveiga
Copy link
Contributor

Description
Fixes customer return validation for return items without inventory units.

Fixes #4059

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @spaghetticode does it look ok for you?

Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kennyadsl yes, LTGM.
@willianveiga thanks for this fix!

@kennyadsl kennyadsl merged commit 58f2e0b into solidusio:master May 21, 2021
@willianveiga willianveiga deleted the feature/fix-validation-for-nil-inventory-unit branch May 21, 2021 12:12
@kennyadsl kennyadsl added the changelog:solidus_core Changes to the solidus_core gem label May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected error while validating customer return with blank return item
3 participants